Changeset 624

Timestamp:

01/25/09 05:47:53 (4 years ago)

Author:

bjourne

Message:

Add a test that detects what is the probable cause for the off by one
error reported in #31.

Files:

• pygtkimageview/tests/test_module.py (modified) (1 diff)

pygtkimageview/tests/test_module.py

@@ -557 +557 @@
-        tool.do_button_press(tool, press_ev)
-        assert tool.do_button_release(tool, rel_ev)
+
+def test_correct_repaint_offset():
+    '''
+    Ensure that there is no off by one error when repainting.
+
+    A 1600*1600 pixbuf viewed in a 700*700 image view widget at zoom
+    1.0 should be perfectly centered so that draw starts at
+    coordinates 450, 450. However, there may be a mishandled floating
+    point conversion which causes the draw to start at 449, 449. See
+    #31.
+    '''
+    class DummyTool(gobject.GObject, gtkimageview.IImageTool):
+        def __init__(self):
+            gobject.GObject.__init__(self)
+            self.drawn_coords = (0, 0)
+        def do_button_press(self, ev_button):
+            pass
+        def do_button_release(self, ev_button):
+            pass
+        def do_motion_notify(self, ev_motion):
+            pass
+        def do_pixbuf_changed(self, reset_fit, rect):
+            pass
+        def do_paint_image(self, opts, drawable):
+            self.drawn_coords = opts.zoom_rect.x, opts.zoom_rect.y
+        def do_cursor_at_point(self, x, y):
+            pass
+    gobject.type_register(DummyTool)
+
+    pixbuf = gdk.Pixbuf(gdk.COLORSPACE_RGB, False, 8, 1600, 1600)
+    tool = DummyTool()
+
+    view = gtkimageview.ImageView()
+    view.set_tool(tool)
+    view.set_show_frame(False)
+    view.set_pixbuf(pixbuf)
+    view.size_allocate((0, 0, 700, 700))
+    view.window = gdk.Window(None,
+                             700, 700,
+                             gdk.WINDOW_TOPLEVEL,
+                             0,
+                             gdk.INPUT_OUTPUT)
+    view.set_zoom(1.0)
+    ev = gdk.Event(gdk.EXPOSE)
+    ev.area = view.allocation
+    view.do_expose_event(view, ev)
+    assert tool.drawn_coords == (450, 450)
+