Changeset 657 for plgtkimageview

Show
Ignore:
Timestamp:
04/03/09 20:38:46 (4 years ago)
Author:
jeffrey
Message:

Fixed segfault on $selector->set_selection(undef)

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • plgtkimageview/ImageToolSelector.xs

    r655 r657  
    9292=over 
    9393 
    94 =item If the views pixbuf is NULL. 
     94=item If the views pixbuf is undef. 
    9595 
    9696=item If rect is wider or taller than the size of the pixbuf 
    …… 
    120120gtk_image_tool_selector_set_selection (selector, rect) 
    121121                GtkImageToolSelector *  selector 
    122                 GdkRectangle_ornull *   rect 
    123  
     122                GdkRectangle *          rect 

  • plgtkimageview/t/imagetoolselector.t

    r462 r657  
    66# change 'tests => 1' to 'tests => last_test_to_print'; 
    77 
    8 use Test::More tests => 6; 
     8use Test::More tests => 7; 
    99 
    1010BEGIN { 
    …… 
    3030ok(! defined $rectangle, 'get_selection() initially undefined'); 
    3131 
     32ok(! eval {$selector->set_selection(undef)}, '$selector->set_selection(undef) throws error' ); 
     33 
    3234$rectangle = Gtk2::Gdk::Rectangle->new(0,0,10,10); 
    3335$selector->set_selection($rectangle);