{5} All tickets (verbose) (30 matches)

This is good

None of the source or documentation states what the license is. Ideally there would be a COPYING for GPL, or COPYING.LIB for LGPL at the top level with the complete license in, and every file should state the copyright owner and license.

When checking the type of arguments it is conventional to use g_return_(val)_if_fail() not g_assert(). It's good to be strict, but not that strict. :)

All headers are installed, but not all of them form the public API.

Attaching a patch to only install the public API, and clean up the includes.

Attaching a patch to make the private fields in GtkImageView actually private, instead of being exposed to the world.

If you apply this, apply it before the interpolation patch (#8) or the headers patch (#7) to reduce conflicts.

The function mouse_handler_handle_motion_notify() returns a void, but should return a gboolean to report that it handled the event.

Udi

This bug can be reproduced using the source:/gtkimageview/tests/ex-alignment.c program. The infinite loop occurs when the GtkImageScrollWin tries to show the scrollbars. Press + twice to see the bug.

There is a debugging printf() in gtkimagetoolselector.c

Also on win32, gcc complains that there is a missing return in hotspot_list_find_hotspot() after g_assert_not_reached()

gtkimageview-1.4.0:

cc1: warnings being treated as errors
gtkimagetoolselector.c: In function 'gtk_image_tool_selector_set_selection':
gtkimagetoolselector.c:718: warning: 'wid_old.x' may be used uninitialized in this function
gtkimagetoolselector.c:718: warning: 'wid_old.y' may be used uninitialized in this function
gtkimagetoolselector.c:718: warning: 'wid_old.width' may be used uninitialized in this function
gtkimagetoolselector.c:718: warning: 'wid_old.height' may be used uninitialized in this function
gtkimagetoolselector.c:718: warning: 'wid_new.x' may be used uninitialized in this function
gtkimagetoolselector.c:718: warning: 'wid_new.y' may be used uninitialized in this function
gtkimagetoolselector.c:718: warning: 'wid_new.width' may be used uninitialized in this function
gtkimagetoolselector.c:718: warning: 'wid_new.height' may be used uninitialized in this function
make[2]: *** [gtkimagetoolselector.lo] Fehler 1
make[2]: *** Warte auf noch nicht beendete Prozesse...

Tested with ufraw-0.12.1. After image is being loaded, the gtkimageview shows black rectangle instead of it. This effect persists after window redraw (minimize and restore window), but when the image is scrolled, newly displayed image parts (which are shown as a result of scrolling) are displayed correctly. Gtkimageview-1.3.0 doesn't have this bug. I use gtk+-2.10.12.

GtkImageView crashes with the following message when using the horizontal mouse wheel. This is reproducible on the 'interactive' test program.

** ERROR:(gtkimageview.c:897):gtk_image_view_scroll_event: assertion failed: (ev->direction == GDK_SCROLL_UP

Using the following code, slide the separator all the way to the left. The program freezes.

import gtk
import gtkimageview

imageview = gtkimageview.ImageView()
imageview.set_pixbuf(gtk.gdk.pixbuf_new_from_file('foobar.png'))
scrolledimageview = gtkimageview.ImageScrollWin(imageview)

paned = gtk.HPaned()
paned.pack1(scrolledimageview)
paned.pack2(gtk.Label('Foo'))

window = gtk.Window(gtk.WINDOW_TOPLEVEL)
window.set_title('Test')
window.add(paned)
window.show_all()

gtk.main()

It appears that web browsers use black magic to figure out the actual delay between frames, and people have come to rely on this. This should probably be fixed in GTK+, but what I've done as a workaround is to replace (in gtkanimview.c) the two instances of:

aview->timer_id = g_timeout_add (aview->delay,

with

aview->timer_id = g_timeout_add (aview->delay < MIN_DELAY ? MIN_DELAY : aview->delay,

A minimum delay of 50 seems to work.

I am maintaining gtkimageview in pkgsrc, and normally one specifies an unchanging MASTER_SITE, and a DISTNAME, and has a default suffix (.tar.gz). But the URL for each tarball changes with version. It would be really nice to put them in a directory on the web server where they can be fetched normally, without interacting with trac, and just link to that, instead of using trac attachments.

Your progressive loading example now confirms that this is a bug and not just me using your code incorrectly. The initial frame of a gif animation isn't displayed (it should load progressively like a static image). This workaround shows the desired operation:

def on_area_prepared(l):
        view.set_anim(None)
        view.set_is_playing(False)
        pixbuf = l.get_pixbuf()
        pixbuf.fill(0)
        view.set_pixbuf(pixbuf)
loader.connect('area-prepared', on_area_prepared)
def on_area_updated(l, x, y, w, h):
        anim = l.get_animation()
        if anim.is_static_image(): view.damage_pixels((x, y, w, h))
        else:
                view.set_anim(anim)
                l.disconnect(area_updated_connection)
area_updated_connection = loader.connect('area-updated', on_area_updated)

Also, you should probably use gdk_pixbuf_animation_iter_on_currently_loading_frame to pause on the currently loading frame.

Finally, try pressing J while a static image is being displayed (the program freezes).