Ticket #9 (closed: wontfix)

Opened 6 years ago

Last modified 4 years ago

Use a private struct instead of expose implementation

Reported by: guest Assigned to:
Keywords: Cc: ross@burtonini.com

Description

Attaching a patch to make the private fields in GtkImageView actually private, instead of being exposed to the world.

If you apply this, apply it before the interpolation patch (#8) or the headers patch (#7) to reduce conflicts.

Attachments

gtkimageview-private.diff (27.1 kB) - added by guest on 04/19/07 09:15:00.

Change History

04/19/07 09:15:00 changed by guest

  • attachment gtkimageview-private.diff added.

04/19/07 09:15:41 changed by guest

Sadly the patch had to disable one of the tests. Really test suites like that should be part of the source itself, optionally compiled (see DBus).

04/19/07 23:35:05 changed by bjourne

Thanks, I'm not sure I agree with the patch. I know using the pimpl idiom is very customary in GObject code, but it is also so very ugly. Wouldn't just padding the struct with reserved fields be enough to maintain ABI compatibility?

04/20/07 06:41:15 changed by guest

The point isn't just ABI, but hiding the implementation details like the mouse handler. At the moment you have to install headers for the internal functions, which means that size.c, mouse_handler.c and so on are part of the ABI too.

06/06/09 00:50:31 changed by bjourne

  • status changed from new to closed.
  • resolution set to wontfix.

The library seem to have been working well enough without the private structs. So I'll keep it that way because it's to much work to change.